Extend `_tensor_elementwise_impl` (unary) part 2 by vlad-perevezentsev · Pull Request #2796 · IntelPython/dpnp

vlad-perevezentsev · 2026-03-04T17:16:52Z

This PR extends _tensor_elementwise_impl with part of the unary functions: cos, cosh, exp, expm1, floor, imag, isfinite, isinf, isnan, log, log1p, log2, log10, logical_not, negative, positive

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
Have you added documentation for your changes, if necessary?
Have you added your changes to the changelog?

…pl_unary

…_impl_unary_par_2

ndgrigorian

I looked over includes and nothing stood out, this one LGTM

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/floor.hpp

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/logical_not.hpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/imag.cpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/isfinite.cpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/isinf.cpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/isnan.cpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/log.cpp

dpctl_ext/tensor/libtensor/source/elementwise_functions/log1p.cpp

dpnp/dpnp_iface_logic.py

…_impl_unary_par_2

The base branch was changed.

github-actions · 2026-03-16T14:38:44Z

Array API standard conformance tests for dpnp=0.20.0dev3=py313h509198e_197 ran successfully.
Passed: 1355
Failed: 2
Skipped: 16

antonwolfy

LGTM with small nits below

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/logical_not.hpp

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/negative.hpp

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/positive.hpp

vlad-perevezentsev added 30 commits February 3, 2026 12:16

Rename folder dpctl to dpctl_ext

d4fd805

Add simplify_iteration_space implementation to libtensor

c040713

Extend codespell ignore list for libtensor

14b466f

Add copy_and_cast kernels to libtensor

dcc421b

Add copy_usm_ndarray_into_usm_ndarray implementation

5a9c14c

Add pybind11 bindings for dpctl_ext.tensor._tensor_impl

4f63340

Add CMake build files for dpctl_ext

634579c

Add empty __init__ to dpctl_ext/

79d40f2

Enable _same_logical_tensors in _tensor_impl

7949c17

Add device_support_queries to enable default device types

29d6c02

Enable building and packaging of dpctl_ext

936e719

Use _tensor_impl from dpctl_ext.tensor in dpnp

cd85f1e

Move put() and take() to dpctl_ext/tensor

0c6780a

Use put/take from dpctl_ext.tensor in dpnp

87e5482

Move full() to dpctl_ext/tensor

b537f30

Use full and _full_usm_ndarray from dpctl_ext in dpnp

d50f263

Update .gitignore to ignore .so files in dpctl_ext

f189dc5

Move _zeros_usm_ndarray to dpctl_ext

f9a1817

Use _zeros_usm_ndarray from dpctl_ext in dpnp_fill.py

4b8505a

Move linear-sequence implementations to dpctl_ext/tensor

61106b2

Use _tensor_impl from dpctl_ext in dpnp_utils_fft.py

a030579

Move tril()/triu() to dpctl_ext/tensor

a1d6fa3

Use tril/triu/_tril from dpctl_ext.tensor in dpnp

f1d6e56

Disable pylint no-name-in-module for dpctl_ext

6680790

Add TODO comments

263b717

Use default_device_complex_type from dpctl_ext on test_array_api_info.py

4130c1b

Remove unused build_dpctl_ext function

17ca9ab

Apply remarks for CMake files

79cb2a4

Apply remarks for c++ files

4bf080e

Remove linear-sequence implementations

cfa6cd6

vlad-perevezentsev added 7 commits March 5, 2026 12:05

Merge move_tensor_sorting_impl into move_tensor_reductions_impl_ext

c9644ac

Merge move_tensor_reductions_impl_ext into move_tensor_elementwise_im…

6a2c31b

…pl_unary

Merge move_tensor_elementwise_impl_unary into move_tensor_elementwise…

9339cb8

…_impl_unary_par_2

Merge include-dpctl-tensor into move_tensor_elementwise_impl_unary

5d11ff7

Apply remarks

281adbf

Merge move_tensor_elementwise_impl_unary into move_tensor_elementwise…

7b63ab5

…_impl_unary_par_2

Clean-up includes

a2d28af

vlad-perevezentsev marked this pull request as ready for review March 11, 2026 13:24

vlad-perevezentsev requested review from antonwolfy and ndgrigorian as code owners March 11, 2026 13:24

Small clean-up bitwise_invert.hpp

d5bbfc0

ndgrigorian previously approved these changes Mar 12, 2026

View reviewed changes

antonwolfy reviewed Mar 12, 2026

View reviewed changes

vlad-perevezentsev added 3 commits March 13, 2026 04:37

Apply remarks

d80a7dc

Merge move_tensor_elementwise_impl_unary into move_tensor_elementwise…

2d5b148

…_impl_unary_par_2

Apply remarks

9ce7e7f

Base automatically changed from move_tensor_elementwise_impl_unary to include-dpctl-tensor March 16, 2026 13:18

vlad-perevezentsev added 2 commits March 16, 2026 06:21

Merge include-dpctl-tensor into move_tensor_elementwise_impl_unary_par_2

d5d0e36

Update a wrong function name in docs

ffee731

antonwolfy previously approved these changes Mar 17, 2026

View reviewed changes

antonwolfy reviewed Mar 17, 2026

View reviewed changes

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/logical_not.hpp Outdated Show resolved Hide resolved

antonwolfy reviewed Mar 17, 2026

View reviewed changes

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/negative.hpp Outdated Show resolved Hide resolved

antonwolfy reviewed Mar 17, 2026

View reviewed changes

dpctl_ext/tensor/libtensor/include/kernels/elementwise_functions/positive.hpp Outdated Show resolved Hide resolved

Apply remarks

b1c213d

vlad-perevezentsev dismissed antonwolfy’s stale review via b1c213d March 17, 2026 17:16

antonwolfy approved these changes Mar 17, 2026

View reviewed changes

vlad-perevezentsev merged commit ce5f54e into include-dpctl-tensor Mar 17, 2026
60 of 79 checks passed

vlad-perevezentsev deleted the move_tensor_elementwise_impl_unary_par_2 branch March 17, 2026 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend `_tensor_elementwise_impl` (unary) part 2#2796

Extend `_tensor_elementwise_impl` (unary) part 2#2796
vlad-perevezentsev merged 179 commits intoinclude-dpctl-tensorfrom
move_tensor_elementwise_impl_unary_par_2

vlad-perevezentsev commented Mar 4, 2026 •

edited

Loading

Uh oh!

ndgrigorian left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

antonwolfy left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vlad-perevezentsev commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

antonwolfy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vlad-perevezentsev commented Mar 4, 2026 •

edited

Loading

antonwolfy left a comment •

edited

Loading